Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drilldowns] improve dashboard link generator to support dashboard-to-dashboard drilldown #61307

Merged
merged 5 commits into from
Mar 31, 2020
Merged

[Drilldowns] improve dashboard link generator to support dashboard-to-dashboard drilldown #61307

merged 5 commits into from
Mar 31, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Mar 25, 2020 •
edited
Loading

Summary

Part of #61230
Originally done in dashboard to dashboard drilldown pr: #60087, but extracting into separate pr

This pr:

  1. Leverage info if filter is pinned or not to decide if to put it into _a or _g param
  2. Support for refresh interval in _g
  3. For sanity, clean up empty keys.

Testing

Not sure how to real world test it, as it will be actually used in #60087

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@Dosant Dosant mentioned this pull request Mar 25, 2020
Closed
7 tasks
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant added v7.8 Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0 and removed v7.8 labels Mar 25, 2020
@Dosant Dosant marked this pull request as ready for review March 25, 2020 18:12
@Dosant Dosant requested review from a team and stacey-gammon March 25, 2020 18:12
stacey-gammon
stacey-gammon approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/plugins/dashboard/public/url_generator.ts Outdated Show resolved Hide resolved
@Dosant
Copy link
Contributor Author

Dosant commented Mar 30, 2020

@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented Mar 31, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 25a1119 into elastic:master Mar 31, 2020
Dosant added a commit to Dosant/kibana that referenced this pull request Mar 31, 2020
@Dosant @elasticmachine
[Drilldowns] improve dashboard link generator to support dashboard-to…
5a74052 
…-dashboard drilldown (elastic#61307)

* improve dashboard link generator to support dashboard-to-dashboard drilldown

* any -> unknown

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@Dosant Dosant mentioned this pull request Mar 31, 2020
Merged
Dosant added a commit that referenced this pull request Mar 31, 2020
@Dosant @elasticmachine
[Drilldowns] improve dashboard link generator to support dashboard-to…
8218a5d 
…-dashboard drilldown (#61307) (#61956)

* improve dashboard link generator to support dashboard-to-dashboard drilldown

* any -> unknown

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majagrubic majagrubic majagrubic approved these changes

@stacey-gammon stacey-gammon stacey-gammon approved these changes

Assignees
No one assigned
Labels
Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Dosant @elasticmachine @kibanamachine @majagrubic @stacey-gammon